Skip to content

Commit

Permalink
allow for TLSv1 tests to work with node 18 as the express server runn…
Browse files Browse the repository at this point in the history
…ing node 18 with tlsv1 needs to allow legacy ciphers
  • Loading branch information
AtofStryker committed Aug 31, 2023
1 parent 3606080 commit f48a01e
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions system-tests/scripts/run.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ const isWindows = () => {
const isGteNode12 = () => {
return Number(process.versions.node.split('.')[0]) >= 12
}
const isGteNode18 = () => {
return Number(process.versions.node.split('.')[0]) >= 18
}

if (!run || !run.length) {
return exitErr(`
Expand Down Expand Up @@ -86,6 +89,14 @@ if (isGteNode12()) {
)
}

// allow all ciphers to test TLSv1 in Node 18+ for express hosted servers in system tests
if (isGteNode18()) {
// https://github.com/nodejs/node/issues/49210
commandAndArguments.args.push(
`--tls-cipher-list=DEFAULT@SECLEVEL=0`,
)
}

if (!isWindows()) {
commandAndArguments.args.push(
'node_modules/.bin/_mocha',
Expand Down

0 comments on commit f48a01e

Please sign in to comment.