Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domain parsing fails when local or localhost is not the tld #1292

Closed
brian-mann opened this issue Feb 11, 2018 · 1 comment
Closed

Domain parsing fails when local or localhost is not the tld #1292

brian-mann opened this issue Feb 11, 2018 · 1 comment
Assignees
@brian-mann
Labels
type: bug
Milestone
2.0.0

Comments

@brian-mann
Copy link
Member

There was a regression in 1.4.2

Per these issues:

Our domain parsing rules expect local and localhost to always be TLD's but this is not the case. We can relax the domain parsing rules to only factor in ip addresses, and everything else can use the naive check of segment splitting.

Since we're now taking into account private tld's, this should work correctly now.
@brian-mann brian-mann added this to the 2.0.0 milestone Feb 11, 2018
@brian-mann brian-mann self-assigned this Feb 11, 2018
brian-mann added a commit that referenced this issue Feb 11, 2018
@brian-mann
server, driver: fixes #1292 relax domain parsing rules and fallback t…
85f73c6 
…o naive segment parsing to fix local and localhost
This was referenced Feb 11, 2018
Closed
Closed
@brian-mann
Copy link
Member Author

Released in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
type: bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@brian-mann