Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appending errors with no messages leads to hilarity #1338

Closed
brian-mann opened this issue Feb 18, 2018 · 1 comment
Closed

Appending errors with no messages leads to hilarity #1338

brian-mann opened this issue Feb 18, 2018 · 1 comment
Assignees
@brian-mann
Labels
type: bug
Milestone
2.0.2

Comments

@brian-mann
Copy link
Member

Throwing an error with no message ends up creating a massive repeating stack trace due to splitting on the error.message and then rejoining later.

beforeEach(() => {
  throw new Error()
})

it(...)
@brian-mann brian-mann added this to the 2.0.2 milestone Feb 18, 2018
@brian-mann brian-mann self-assigned this Feb 18, 2018
brian-mann added a commit that referenced this issue Feb 18, 2018
@brian-mann
driver: fixes #1338, more intelligently parse + append error messages
9ed2777 
- better handling of empty messages
- better handling of error messages that have strings found inside the
stack
@brian-mann
Copy link
Member Author

Released in 2.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
type: bug
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
1 participant
@brian-mann