fix: update dependencies of npm/react-vue #15095
Conversation
BREAKING CHANGE: change of architecture for component testing
|
Thanks for taking the time to open a PR!
|
| @@ -37,6 +36,7 @@ | |||
| "@babel/preset-typescript": "7.10.4", | |||
| "@bahmutov/cy-api": "1.4.2", | |||
| "@bahmutov/cy-rollup": "2.0.0", | |||
| "@cypress/webpack-dev-server": "0.0.0-development", | |||
There was a problem hiding this comment.
Will this work for the published package? Does semantic release automatically inject correct version?
There was a problem hiding this comment.
Since webpack-dev-server is not published yet, this is the only version that yarn will accept.
I believe the dependencies to be updated by server automatically at release but I will check the script.
It's better to be safe than sorry.
There was a problem hiding this comment.
I just checked, and it does do it for webpack-preprocessor.
We should be OK.
We can always deliver a new fixed version later by merging on master if it was not the case.
| @@ -12,26 +12,26 @@ | |||
| "watch": "tsc -w" | |||
| }, | |||
| "dependencies": { | |||
| "@babel/plugin-transform-modules-commonjs": "7.10.4", | |||
| "@cypress/code-coverage": "3.8.1", | |||
There was a problem hiding this comment.
I think that we are not connecting it by default anymore?
There was a problem hiding this comment.
... We are, but maybe we should not.
BREAKING CHANGE: change of architecture for component testing