Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix cypress scripts on windows #15492

Merged
merged 4 commits into from
Mar 16, 2021
Merged

chore: fix cypress scripts on windows #15492

merged 4 commits into from
Mar 16, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Mar 15, 2021

Removed bash-isms that won't work on Windows cmd.exe.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 15, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Mar 15, 2021



Test summary

9388 0 119 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 38b01cb
Started Mar 16, 2021 2:31 AM
Ended Mar 16, 2021 2:44 AM
Duration 12:47 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like really weird workaround, I don't understand why this might not work on windows but I trust that this is required :)

@flotwig
Copy link
Contributor Author

flotwig commented Mar 15, 2021

cmd.exe doesn't support substituting commands like that

@flotwig flotwig merged commit a8b9917 into develop Mar 16, 2021
This was referenced Mar 18, 2021
This was referenced Mar 18, 2021
elevatebart pushed a commit that referenced this pull request Mar 18, 2021
Co-authored-by: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
@flotwig flotwig deleted the issue-8783 branch January 24, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Developing on windows has a broken workflow (or contributing instructions incorrect)
2 participants