fix: add missing script for building wizard #15502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
dmtrKovalenko
previously approved these changes
Mar 15, 2021
| ```json | ||
| { | ||
| "experimentalComponentTesting": true, | ||
| "componentFolder": "src" |
There was a problem hiding this comment.
It's still required, isn't it?
There was a problem hiding this comment.
It is not required anymore since we do not use preprocessors.
We should update the wizard, I will make a ticket.
There was a problem hiding this comment.
No componentFolder is still required in order to find distinguish component specs and e2e specs.
There was a problem hiding this comment.
Why isn't it a default?
I'll fix it
|
Cypress throws the following error: animation_coords_history_invalid: 'coordsHistory must be at least 2 sets of coords',I give up for tonight. |
elevatebart
added a commit
that referenced
this pull request
Mar 18, 2021
* fix: add missing script for building wizard * docs: readme needs componentFolder * fix: make build script work on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #15450 we need to deliver the wizard again and probably update the Readme.md for
@cypress/react.