fix: improve handling of userland injected styles in component testing #16024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
5 tasks
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
agg23
previously approved these changes
Apr 16, 2021
agg23
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Injected styles via styled components get cleaned up after each spec.
Additional details
We no longer clean up
<head>. This is more in line with what users expect. If they are using a library likestyled-components, which injects stylesheets into<head>, those will be persisted between tests. We do clean up stylesheets injected via themountoptions.I also added a
@cypress/mount-utilspackage. Now the style injecting/clean up is consistent between both Vue and React. Furthermore, now Vue and React both have the same mounting options forstyles. This was not the case previously - due to copy-pasting, they were mostly the same, but not quite. This package will be useful moving forward for other adapters, like Angular, which is discussed here.NOTE: These changes will need to be ported to the Vue 3 branch, too. I guess we just do that as soon as this is merged into master and the
@cypress/mount-utilspackage is published on npm.How has the user experience changed?
Userland styles are not nuked between tests. Subsequent tests are able to retain and use the injected styles.
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?