fix: Properly display unmount as a command #16041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
lmiller1990
previously approved these changes
Apr 19, 2021
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
agg23
requested review from
chrisbreiding and
kuceb
and removed request for
a team
chrisbreiding
approved these changes
Apr 20, 2021
lmiller1990
approved these changes
Apr 21, 2021
|
Should this be targeting Either way added a ✅ , merge when you are ready. |
tgriesser
added a commit
that referenced
this pull request
Apr 21, 2021
…press into tgriesser/chore/improve-ci * 'tgriesser/chore/improve-ci' of github.com:cypress-io/cypress: fix(deps): update dependency systeminformation to version 5.6.4 🌟 (#15819) docs: fix a typo of package name [skip ci] (#15783) chore: deduplicate yarn.lock (#15988) fix(webpack): allow load custom asset on windows (#16099) fix: Properly display unmount as a command (#16041) fix(component-testing): correct imports for relative paths in cypress.json (#16056) Fixed missing SearchInput and improved SpecList scrolling (#16090) docs: update react docs (#16055) chore: Design System Cleanup (#16077) feat(component-testing): breaking: Add React rerender functionality (#16038) fix(component-testing): Increased timeout to allow useEffect to trigger (#16091) chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Entry for
unmountin the CommandLog is more prominent and displays more information.How has the user experience changed?
Before:
After:
