fix(npm/react): support transpiling typescript files in support #16197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lmiller1990
requested review from
elevatebart,
agg23,
jennifer-shehane and
JessicaSachs
and removed request for
jennifer-shehane
agg23
approved these changes
Apr 26, 2021
elevatebart
added a commit
that referenced
this pull request
May 5, 2021
* fix: transpile typescript in supportFolder for react-scripts * lint * lint * lint * lint * update package.json deps * Remove yarn lock * inject dev serverg * add circleci reporter Co-authored-by: Barthélémy Ledoux <bart@cypress.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Transpile TypeScript files in
cypress/supportwhen using thereact-scripts(Create React App) plugin for Component Testing.Additional details
CRA has a "feature" where it will not transpile (or even support) importing files outside
src. A common cypress idiom is to keep cypress specific code incypress. We already have special rules supporting transpiling/importing code fromfixturesandcommands. Now we have it for support, too.The important part to review is here. I just followed the existing pattern.
How has the user experience changed?
You may now use TS inside of
support, for examplesupport/index.ts.PR Tasks