Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(npm/react): Add craco plugin #16333

Merged
merged 4 commits into from
May 5, 2021
Merged

feat(npm/react): Add craco plugin #16333

merged 4 commits into from
May 5, 2021

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented May 5, 2021 •
edited

User facing changelog

Add a plugin to support configuring CRACO (Create React App Configuration Override) with Cypress component testing.

Additional details

Make the process of using CRACO with Cypress CT easier. CRACO has 160k npm downloads / week, seems like it's worth supporting this out of the box.

The main files you want to review are:

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 5, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 added npm: @cypress/webpack-dev-server @cypress/webpack-dev-server package issues npm: @cypress/react @cypress/react package issues and removed npm: @cypress/webpack-dev-server @cypress/webpack-dev-server package issues labels May 5, 2021
@cypress
Copy link

cypress bot commented May 5, 2021 •
edited


Test summary

458 • 0 • 6 • 0 • Flakiness 0

Run details
Project cypress
Status Passed
Commit c0b1e45
Started May 5, 2021 6:01 AM
Ended May 5, 2021 6:11 AM
Duration 10:02 💡
OS Linux Debian - 10.8
Browser Electron 89

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 merged commit 958a9c2 into develop May 5, 2021
@lmiller1990 lmiller1990 deleted the add-cra-override-config-plugin branch May 5, 2021 14:33
elevatebart pushed a commit that referenced this pull request May 5, 2021
@lmiller1990 @elevatebart
feat(npm/react): Add craco plugin (#16333)
2d8f55b 
* add craco example

* feat: add craco plugin

* update readme

* remove old files
@lmiller1990 lmiller1990 mentioned this pull request May 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agg23 agg23 agg23 approved these changes

@elevatebart elevatebart Awaiting requested review from elevatebart

Assignees
No one assigned
Labels
npm: @cypress/react @cypress/react package issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ship craco (CRA config override) adapter in cypress/react
2 participants
@lmiller1990 @agg23