feat: exclude html pwa plugin in webpack dev server #16388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
lmiller1990
added
component testing
npm: @cypress/webpack-dev-server
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
agg23
approved these changes
May 7, 2021
tgriesser
added a commit
that referenced
this pull request
May 10, 2021
* develop: remove unused deps from webpack-preprocessor (#16384) feat: exclude html pwa plugin in webpack dev server (#16388) fix(ui): display duplicate aliases in command log (#16382) fix(ui): show req stub/fn when a handler is supplied (#16383) feat(component-testing): Expose CT through CLI module API (#16368)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Remove
HtmlPwaPluginfrom webpack in dev server.Additional details
This plugin depends on
html-webpack-plugin@3which is two minor versions behind - something we do not support at the present time. Until we find a better long term solution, it's a better DX to just remove it so users do not need to manually exclude it. As noted in the README this plugin uses a service worker which is only enabled in production anyway.How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?