Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm/react): remove unnecessary dependency #16412

Merged
merged 2 commits into from
May 11, 2021

Conversation

lmiller1990
Copy link
Contributor

User facing changelog

Remove unnecessary @cypress/webpack-preprocessor dependency from @cypress/react.

Additional details

@cypress/react should not be coupled to or require any webpack specific dependencies.

How has the user experience changed?

Fixes problem where npm 7 raises an error related to dependencies on installation.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 10, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 changed the base branch from develop to master May 10, 2021 02:21
@@ -42,7 +41,6 @@
"@material-ui/icons": "4.5.1",
"@material-ui/lab": "4.0.0-alpha.39",
"@material-ui/pickers": "3.2.10",
"@percy/cypress": "2.3.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used

@cypress
Copy link

cypress bot commented May 10, 2021



Test summary

13841 0 164 5Flakiness 0


Run details

Project cypress
Status Passed
Commit 211e7cd
Started May 11, 2021 1:44 AM
Ended May 11, 2021 1:56 AM
Duration 11:43 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 merged commit 7b242ac into master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peer dependency issue - @cypress/webpack-preprocessor doesn't support webpack@^5
2 participants