Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent mount .wrap command appearing in log #16585

Merged
merged 2 commits into from
May 19, 2021

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented May 19, 2021

User facing changelog

Removes unnecessary wrap command appearing in the Cypress CommandLog when mounting a React component.

Additional details

Every time mount is run, it is logging a wrap command as well. This is unnecessary clutter and it isn't supposed to be displayed to the user (it probably started showing because of a bad merge).

How has the user experience changed?

Before:
Screen Shot 2021-05-19 at 5 37 15 AM

After:
Screen Shot 2021-05-19 at 5 36 50 AM

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 19, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented May 19, 2021



Test summary

17945 0 214 7Flakiness 2


Run details

Project cypress
Status Passed
Commit 0b52a2b
Started May 19, 2021 12:47 PM
Ended May 19, 2021 12:58 PM
Duration 11:21 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes
2 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am with you on this one !!
That would help

@agg23 agg23 merged commit fca9b9a into develop May 19, 2021
@jennifer-shehane
Copy link
Member

@agg23 This looks like the code is only affecting an npm modules. Removing from the 7.4.0 release since it doesn't touch the binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants