Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress/react): add default webpack config path #16813

Merged
merged 7 commits into from
Jun 4, 2021

Conversation

lmiller1990
Copy link
Contributor

User facing changelog

#16751 added a config object to modify the webpack config path. We need a default for users who are not providing the configuration object.

Additional details

This is very awkward to test. We'd need another entire project - should look into this, but this fix is pretty important to get out, so I just tested it by creating a project, reproducing the error, then updating node_modules.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 4, 2021

Thanks for taking the time to open a PR!

elevatebart
elevatebart previously approved these changes Jun 4, 2021
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would say that's a woops

@cypress
Copy link

cypress bot commented Jun 4, 2021



Test summary

17968 0 214 7Flakiness 0


Run details

Project cypress
Status Passed
Commit 53d4657
Started Jun 4, 2021 4:05 PM
Ended Jun 4, 2021 4:17 PM
Duration 11:54 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 requested a review from a team as a code owner June 4, 2021 15:41
@lmiller1990 lmiller1990 requested review from kuceb and removed request for a team June 4, 2021 15:41
elevatebart
elevatebart previously approved these changes Jun 4, 2021
Copy link
Contributor

@elevatebart elevatebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With an example test? Even better !

@lmiller1990 lmiller1990 requested review from elevatebart and removed request for kuceb June 4, 2021 16:26
@elevatebart elevatebart merged commit 0348170 into master Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants