Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin for next 11.0.2 moved webpack-config #17529

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Jul 29, 2021

User facing changelog

A change in NextJs 11.0.2-canary.20's internal structure of next made cypress plugin error with a file not found. This fixes it.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 29, 2021



Test summary

18192 0 214 7Flakiness 1


Run details

Project cypress
Status Passed
Commit 8be901d
Started Jul 31, 2021 3:51 AM
Ended Jul 31, 2021 4:02 AM
Duration 10:59 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting request > can intercept utf-8 request bodies without crashing

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test? Just creating a new project?

We need to find a better strategy. I think this should be a separate module where the version is the same as the Next.js version that it works with. Like how ts-jest matches vue-jest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants