Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definition for Cypress.minimatch is missing function signature #1902

Closed
bahmutov opened this issue Jun 7, 2018 · 1 comment · Fixed by #1903
Closed

Type definition for Cypress.minimatch is missing function signature #1902

bahmutov opened this issue Jun 7, 2018 · 1 comment · Fixed by #1903
Assignees
@bahmutov
Labels
topic: typescript
Milestone
3.0.2

Comments

@bahmutov
Copy link
Contributor

bahmutov commented Jun 7, 2018

missing type definition

We include Cypress.minimatch type, but it is missing that it can be called as a function

cypress/integration/examples/utilities.spec.js:49:22 - error TS2348: Value of type 'IMinimatchStatic' is not callable. Did you mean to include 'new'?

49     const matching = Cypress.minimatch('/users/1/comments', '/users/*/comments', {
                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
50       matchBase: true,
   ~~~~~~~~~~~~~~~~~~~~~~
51     })
@bahmutov bahmutov self-assigned this Jun 7, 2018
bahmutov added a commit that referenced this issue Jun 7, 2018
@bahmutov
types: minimatch is a function, close #1902
68a6fc5
@bahmutov bahmutov mentioned this issue Jun 7, 2018
Merged
brian-mann pushed a commit that referenced this issue Jun 8, 2018
@bahmutov @brian-mann
Ts definition for clear local storage 1899 (#1903)
ff58367 
* types: clearLocalStorage yields localStorage, close #1899

* types: minimatch is a function, close #1902
@brian-mann brian-mann added this to the 3.0.2 milestone Jun 29, 2018
@brian-mann
Copy link
Member

Released in 3.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bahmutov bahmutov

Labels
topic: typescript
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

Ts definition for clear local storage 1899 cypress-io/cypress
3 participants
@brian-mann @jennifer-shehane @bahmutov