Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Lodash as dependency #19205

Open
304NotModified opened this issue Dec 2, 2021 · 8 comments
Open

Remove Lodash as dependency #19205

304NotModified opened this issue Dec 2, 2021 · 8 comments
Labels
E2E Issue related to end-to-end testing type: breaking change Requires a new major release version type: feature New feature that does not currently exist type: security 🔐 Security related

Comments

@304NotModified
Copy link

What would you like?

Remove lodash as a dependency.

Why is this needed?

Those guys don't take security seriously. See for example CVE-2021-41720

Other

No response

@Narretz
Copy link
Contributor

Narretz commented Dec 2, 2021

But why has the CVE been retracted? Doesn't that mean it was no security issue after all? It's very difficult to piece together some information from a bunch of deleted issues.

@jennifer-shehane
Copy link
Member

We've discussed this before. Just removing the inclusion of these Cypress utilities. We removed Cypress.moment() for example and the reasoning was, people can just include whatever they'd like themselves.

We'd be open to considering this - there would need to be docs and migration guides to guide people on replacement similar to moment had. Probably a MUCH bigger PR and more affecting breaking changes for lodash removal though.

@jennifer-shehane jennifer-shehane added the type: breaking change Requires a new major release version label Dec 2, 2021
@bahmutov
Copy link
Contributor

bahmutov commented Dec 2, 2021 via email

@304NotModified
Copy link
Author

304NotModified commented Dec 2, 2021

But why has the CVE been retracted? Doesn't that mean it was no security issue after all? It's very difficult to piece together some information from a bunch of deleted issues.

I don't know. All the reactions are removed. And that is exactly the issue.

On the personal note, love Lodash

I think I don't like the CVEs: https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=Lodash

@dmethvin-gov
Copy link

Several of those CVEs are not even about lodash, they simply mention it. The lodash list of CVEs is admirably small considering how widely it is used. As for this particular CVE, the archived ticket clearly explains why it is not a vulnerability. The template is controlled by the developer, the user data filling the template is a separate thing and not exploitable.

@304NotModified
Copy link
Author

304NotModified commented Dec 8, 2021

My point is that there are hiding security discussions. It really not OK we should search in web archives for finding a reason why some things are disputed.

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label May 15, 2023
@304NotModified
Copy link
Author

I think this request is still valid

@nagash77 nagash77 added type: feature New feature that does not currently exist type: security 🔐 Security related E2E Issue related to end-to-end testing and removed stale no activity on this issue for a long period labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E Issue related to end-to-end testing type: breaking change Requires a new major release version type: feature New feature that does not currently exist type: security 🔐 Security related
Projects
None yet
Development

No branches or pull requests

7 participants