Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sessions] Collapse Behavior in Command Log #21399

Closed
emilyrohrbough opened this issue May 9, 2022 · 4 comments · Fixed by #22857 or #23984
Closed

[sessions] Collapse Behavior in Command Log #21399

emilyrohrbough opened this issue May 9, 2022 · 4 comments · Fixed by #22857 or #23984
Assignees
@emilyrohrbough
Labels
topic: session Issues when using session command
Milestone
experimentalSessi...

Comments

@emilyrohrbough
Copy link
Member

What would you like?

  • When should it collapse? What should collapse? Etc.
  • Validate and/or correct all collapse behavior
  • Behavior and verbiage for all of: beginning operation, running command within operation, final state once it’s done

Why is this needed?

No response

Other

No response
@emilyrohrbough emilyrohrbough self-assigned this May 9, 2022
@emilyrohrbough emilyrohrbough added the topic: session Issues when using session command label May 9, 2022
@emilyrohrbough emilyrohrbough mentioned this issue Jul 21, 2022
Merged
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 27, 2022

The code for this is done in cypress-io/cypress#22857, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@emilyrohrbough emilyrohrbough mentioned this issue Aug 1, 2022
Merged
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2022

Released in 10.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 2, 2022
@emilyrohrbough
Copy link
Member Author

Noticing this isn't being handled correctly when a command fails the setup func.

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Sep 26, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 1, 2022
@astone123
Copy link
Contributor

Released in 10.10.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.10.0, please open a new issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@emilyrohrbough emilyrohrbough

Labels
topic: session Issues when using session command
Projects
None yet
Milestone
experimentalSessionAndOrigin GA
3 participants
@mjhenkes @emilyrohrbough @astone123