Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser icons and longer names in the dropdown menu don't display correctly #21755

Closed
sync-by-unito bot opened this issue May 30, 2022 · 4 comments · Fixed by #25270
Closed

Browser icons and longer names in the dropdown menu don't display correctly #21755

sync-by-unito bot opened this issue May 30, 2022 · 4 comments · Fixed by #25270
Labels
good first issue Good for newcomers stage: needs review The PR code is done & tested, needs review type: bug

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented May 30, 2022

Two things…

Very low priority but the launchpad browser tile design & associated list doesn’t support longer names. I don’t know of many other than FF Developer Edition. But maybe can truncate the text after a max char count to prevent this.

Also, notice the non-standard Edge logos being squished in the app dropdown.

Screen Shot 2022-03-02 at 5 19 10 PM

Screen Shot 2022-03-02 at 5 16 57 PM

┆Issue is synchronized with this Jira Bug by Unito
┆Attachments: Screen Shot 2022-03-02 at 5.16.57 PM.png | Screen Shot 2022-03-02 at 5.19.10 PM.png
┆author: Paul Jaffre
┆epic: UI/UX Improvements
┆friendlyId: UNIFY-1234
┆priority: Lowest
┆sprint: Unification Release Backlog
┆taskType: Bug

@Manuel-Suarez-Abascal
Copy link
Contributor

@jennifer-shehane I have added a PR addressing this issue here. Let me know your thoughts. Cheers.

@cypress-bot cypress-bot bot added the stage: needs review The PR code is done & tested, needs review label Nov 28, 2022
@jaffrepaul jaffrepaul reopened this Jan 4, 2023
@jaffrepaul
Copy link
Contributor

jaffrepaul commented Jan 4, 2023

There are two areas that need attention in this issue and only one was addressed in 12.3.0. The first image in the original description with the icons being skewed and line breaks on long names is still present.

@jaffrepaul jaffrepaul changed the title Launchpad browser tiles & associated list doesn't support long names Browser icons and longer names in the dropdown menu don't display correctly Jan 4, 2023
@gangaramani-nikhil
Copy link

I can work on this issue

@jaffrepaul
Copy link
Contributor

@cypresschris @marktnoonan It looks like this was closed again but I don't think this has been fixed. There were a few css issues present and the original contribution fixed some of them. Then we reopened it to fix the rest. Should we just add a new issue so we avoid the false positives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers stage: needs review The PR code is done & tested, needs review type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants