Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launchpad): show "connect project" after login if project is not connected #23379

Closed
marktnoonan opened this issue Aug 16, 2022 · 2 comments · Fixed by #23762
Closed

feat(launchpad): show "connect project" after login if project is not connected #23379

marktnoonan opened this issue Aug 16, 2022 · 2 comments · Fixed by #23762
Assignees

Comments

@marktnoonan
Copy link
Contributor

marktnoonan commented Aug 16, 2022

What would you like?

In #23295 we set up the login flow to move into the "Connect Project" flow. This can also reasonably happen from the launchpad. We didn't include the launchpad in the initial PR because it involved some refactoring that would take more time, so we split this into 2 items.

The refactoring that is needed would be:

  • Move all of the "Cloud Connect" components to the frontend-shared package
  • Standardize the login process to always flow into "connect project" if you log in, when a project is open that has no projectId set.
  • Initially this will only work when logging in after a testing type has been chosen, since that is when the config has been parsed. In the future we could grab the config earlier in the process.

It seems possible to group all of this into a single component that can manage both login and cloud-connect flows, since the Cloud Connect modal already prompts you to log in at certain times.

One other thing to be aware of is potentially conflicting changes happening to put a variant of the Cloud Connect flow into the Specs List table rows as part of ACI work in this sprint.

Why is this needed?

No response

Other

No response

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 24, 2022

The code for this is done in cypress-io/cypress#23762, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2022

Released in 10.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants