Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framebusting: window.frameElement #2582

Closed
kuceb opened this issue Oct 9, 2018 · 0 comments · Fixed by #2583
Closed

Framebusting: window.frameElement #2582

kuceb opened this issue Oct 9, 2018 · 0 comments · Fixed by #2583
Assignees
@brian-mann
Milestone
Sprint 9

Comments

@kuceb
Copy link
Contributor

kuceb commented Oct 9, 2018 •
edited

Some framebusting techniques use window.frameElement to detect running in an iframe, we should overwrite window.frameElement in window:before:load

the following code currently frame busts:

if (window.frameElement) { window.top.location = window.location;}
@brian-mann brian-mann mentioned this issue Oct 9, 2018
Merged
@brian-mann brian-mann added this to the Sprint 9 milestone Oct 31, 2018
@brian-mann brian-mann self-assigned this Nov 1, 2018
brian-mann added a commit that referenced this issue Nov 1, 2018
@brian-mann
rewrite frameElement (#2583)
8d12c8d 
- fixes #2582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
None yet
Projects
None yet
Milestone
Sprint 9
Development

Successfully merging a pull request may close this issue.

rewrite frameElement cypress-io/cypress
2 participants
@brian-mann @kuceb