temporary scroll behavior implicitly overrides user preference scrolling #26113
Assignees
Labels
pkg/reporter
This is due to an issue in the packages/reporter directory
Reproducible
Can be reproduced
topic: scrolling ↕️
type: bug
Comments
AtofStryker
added
type: bug
pkg/reporter
3 tasks
3 tasks
AtofStryker
added a commit
that referenced
this issue
Mar 14, 2023
AtofStryker
added a commit
that referenced
this issue
Mar 15, 2023
* fix: Do not magically mutate the user preferences when auto scroll behavior is disabled when a user scrolls or clicks inside the reporter or opens user preferences. Users must explicitly toggle auto-scroll on/off inside the user preferences menu and any implicit behavior will be overidden when this configuration value is set. * [run ci] * chore: add CHANGELOG entry * Update cli/CHANGELOG.md Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> * chore: move bugfix to 12.8.1 in changelog * chore: remove issue 25084 from fix * chore: rename autoScrollingUnderUserPreference to autoScrollingUserPref * empty * Update packages/reporter/src/lib/events.ts Co-authored-by: Mark Noonan <mark@cypress.io> * test: add cy-in-cy regression test to make sure auto scroll is not implicitly turned off * chore: update changelog entry to include #26113 * Update system-tests/projects/cypress-in-cypress/cypress/e2e/dom-content-scrollable-commands.spec.js Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> * chore: update the specs list app test since we have added a new cy-in-cy test * chore: update the specChange-subscription tests * Update CHANGELOG.md * chore: update missed assertion update in spec change subscription --------- Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Mark Noonan <mark@cypress.io>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current behavior
Currently, The cypress app has auto scroll turned on for user preferences by default. However, when a user scrolls mid test, and either clicks on the user preference menu, or clicks on a command in the command log, the auto scroll user preference is implicitly overridden and turned off
Desired behavior
User preferences should never be overridden except explicitly by the user. If a user scrolls while the test is running, the auto scroll may be temporarily disabled, but should not override the preference itself. When the user reruns the test, the user configured preference that is set should persist and override any temporary behavior.
Test code to reproduce
N/A, This is at the reporter level
Cypress Version
10.0.0
Node version
v16.16.0
Operating System
macOS 12.6
Debug Logs
No response
Other
No response
The text was updated successfully, but these errors were encountered: