Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress Runner - New Feature: Default Folders as Closed #26141

Open
zskelton opened this issue Mar 17, 2023 · 10 comments
Open

Cypress Runner - New Feature: Default Folders as Closed #26141

zskelton opened this issue Mar 17, 2023 · 10 comments
Labels
type: enhancement Requested enhancement of existing feature

Comments

@zskelton
Copy link

What would you like?

  1. In Cypress Runner, the tests display always with the folder structure open.
    Requested Feature: Setting in the config file to allow folders to default to closed.

  2. Each Folder in the list is either opened or closed individually.
    Requested Feature: A + and - icon to open/close folders as a group.

Why is this needed?

Allows for visibility of tests in runner to be specific to the group of tests being debugged.

How it Looks Now:

image_1_normal

What Could Be Added:

image_2_concept

Other

No response
@lmiller1990
Copy link
Contributor

VS Code has a similar feature:

image

I agree, our file explorer could definitely do with some improvements. I'lll mark this as a feature request. Is this something you'd be interested in implementing, if we decide to move forward with it?

@lmiller1990 lmiller1990 added the type: enhancement Requested enhancement of existing feature label Mar 20, 2023
@lmiller1990 lmiller1990 self-assigned this Mar 20, 2023
@zskelton
Copy link
Author

zskelton commented Mar 20, 2023 via email

@lmiller1990
Copy link
Contributor

lmiller1990 commented Mar 21, 2023 •
edited

I have done development on windows using git bash at my shell, but only to debug windows specific things... I don't know if anyone at Cypress is doing development on windows on a regular basis, so it is entirely possible something isn't working. If you can share the issue, I can take a look - but to my knowledge, it should work just fine. It should just be yarn to install the deps and yarn dev to get started in watch mode. This is how I develop for Cypress.

As for actually building a binary - I haven't done this on windows, it's definitely working (we release for all platforms every 2 weeks) but I haven't actually built locally on windows before. You shouldn't need to, though - just start the app in watch mode and off you go.

I will need to get some advice/guidance from our design team, I'd recommend waiting until we have something from them, as not to waste your time.

Also, the part of the code that builds the spec list is pretty gnarly, but we have an experimental feature - run all specs that adds a folder level behavior (see the article and GIF) so you might be able to use that code path to implement this.

Please give me a few days to see what the design team thinks is the best way to move forward with this feature request.

@zskelton
Copy link
Author

zskelton commented Mar 21, 2023 via email

@lmiller1990
Copy link
Contributor

I took another look at VS Code. It looks like they do not have a similar feature on a directory-by-directory basis, only a button to do all collapsing/uncollapsing at once.

image

I talked to our design team - a change to the UI has to be carefully considered and weighed up, and this would add quite a lot of extra icons to the UI, and be something that is widely requested.

I'm not sure we will be moving forward with this feature request in the immediate future. For now, we can wait and see if there is more desire for this feature. If more users express a need for this, we can consider it.

@zskelton
Copy link
Author

zskelton commented Mar 23, 2023 via email

@lmiller1990
Copy link
Contributor

@zskelton just another question - is there a particular use case you've got? Do you have a huge amount of specs (like 500+)? Are those E2E or Component specs?

Knowing the use cases can help better prioritize and move feature requests to something we can work on.

@zskelton
Copy link
Author

zskelton commented Mar 27, 2023 via email

@lmiller1990
Copy link
Contributor

lmiller1990 commented Mar 28, 2023 •
edited

Thanks for the feedback; we track all the feedback, once something is requested a few times, and we've got a good idea of the us cases, we will look into it more - for now it's just a nice to have, so I'll leave this one open to get more feedback before we commit to moving forward with any changes.

As an aside, if you've got any feedback around component testing, please let me know 💯

@lmiller1990 lmiller1990 removed their assignment Jun 28, 2023
@DamirPecnik
Copy link

I propose that we configure this in the config file so that when we initiate the cypress open command, triggering our End-to-End (E2E) testing procedure, all folders are automatically set to close. if someone has over 20 folders and over 30 subfolders its hard to turn all of them off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zskelton @DamirPecnik @lmiller1990