Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching by part of a string #29034

Open
szymon-niedrygas opened this issue Feb 29, 2024 · 7 comments · May be fixed by #29464
Open

Searching by part of a string #29034

szymon-niedrygas opened this issue Feb 29, 2024 · 7 comments · May be fixed by #29464
Labels
good first issue Good for newcomers pkg/launchpad This is due to an issue in the packages/launchpad directory stage: needs information Not enough info to reproduce the issue type: user experience Improvements needed for UX

Comments

@szymon-niedrygas
Copy link

What would you like?

Hi Guys,
It would be nice to have a fully working search field works like SQL-like not the test file starts with.
I mean the search field in the Specs tab inside the testrunner.
This is the element that I'm talking about
test runner

Why is this needed?

It's just frustrating

Other

No response
@jennifer-shehane
Copy link
Member

@szymon-niedrygas Can you give an example of a search term you'd like to use and what specs it should match (that is not matching today)?

@jennifer-shehane jennifer-shehane added stage: needs information Not enough info to reproduce the issue type: user experience Improvements needed for UX pkg/launchpad This is due to an issue in the packages/launchpad directory labels Feb 29, 2024
@szymon-niedrygas
Copy link
Author

As you see below I can search by part the name (sorry didn't know it :)) but I can't search by digits
image
image

@jennifer-shehane
Copy link
Member

@szymon-niedrygas That is weird. We'd be open to a PR to address this.

@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label Feb 29, 2024
@migueldsol
Copy link

Hi @jennifer-shehane i was looking into this issue and was able to reproduce it. I think i found a solution for the issue by playing with the sort function threshold. If this is a good solution i would like to create a PR for this.
Screenshot from 2024-04-17 15-35-53

@jennifer-shehane
Copy link
Member

@migueldsol Sure, we can look at that. make sure to include some tests. We have some Cypress tests in our codebase around the search functionality here.

@migueldsol
Copy link

@jennifer-shehane , it seems like you might have missed including the link to the tests. Once I finish them, I'll create a PR.

@jennifer-shehane
Copy link
Member

@migueldsol Here are the tests: https://github.com/cypress-io/cypress/blob/develop/packages/app/cypress/e2e/specs_list_e2e.cy.ts#L149

Here are the instructions on how to get the tests running locally: https://github.com/cypress-io/cypress/blob/develop/packages/app/README.md#development

migueldsol added a commit to migueldsol/cypress that referenced this issue Apr 25, 2024
@migueldsol
fix: Searching by files using digits cypress-io#29034
4d8be17 
When trying to search for a file using digits cypress wasn't able
to find it. Now it is able to do more complex searches with digits
migueldsol added a commit to migueldsol/cypress that referenced this issue May 2, 2024
@migueldsol
fix: Searching by files using digits cypress-io#29034
128935f 
When trying to search for a file using digits cypress wasn't able
to find it. Now it is able to do more complex searches with digits

fix: Searching by files using digits (Fixes cypress-io#29034)
When trying to search for a file using digits cypress wasn't able
to find it. Now it is able to do more complex searches with digits

fix: Searching by files using digits (Fixes cypress-io#29034)

When trying to search for a file using digits cypress wasn't able>
to find it. Now it is able to do more complex searches with digits.>
migueldsol added a commit to migueldsol/cypress that referenced this issue May 2, 2024
@migueldsol
fix: Searching by files using digits (Fixes cypress-io#29034)
a7b983e 
When trying to search for a file using digits cypress wasn't able
to find it. Now it is able to do more complex searches with digits.
@migueldsol migueldsol linked a pull request May 2, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers pkg/launchpad This is due to an issue in the packages/launchpad directory stage: needs information Not enough info to reproduce the issue type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Searching by files using digits (Fixes #29034) migueldsol/cypress
3 participants
@jennifer-shehane @migueldsol @szymon-niedrygas