-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove forked xvfb package from server #29511
Conversation
10 flaky tests on run #55397 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
... > throws when alias property isnt a digit or `all` |
Test Replay
|
scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e
Test | Artifacts | |
---|---|---|
scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite |
Test Replay
Screenshots
|
project-setup.cy.ts • 1 flaky test • launchpad-e2e
Test | Artifacts | |
---|---|---|
... > skips the setup page when choosing e2e tests to run |
Test Replay
Screenshots
|
e2e/origin/navigation.cy.ts • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
delayed navigation > errors > redirects to an unexpected cross-origin and calls another command in the cy.origin command |
Test Replay
|
commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit
Test | Artifacts | |
---|---|---|
network stubbing > intercepting request > can delay and throttle a StaticResponse |
The first 5 flaky specs are shown, see all 8 specs in Cypress Cloud. Review all test suite changes for PR #29511 ↗︎ |
"clean": "node ./scripts/clean.js", | ||
"prebuild": "yarn postinstall && node ./scripts/start-build.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just alphabetizing linting since I touched this file at one point.
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
This removes the package pointing to our https://github.com/cypress-io/node-xvfb git commit.
I did not see this used any longer in the server package. Where
xvfb
is used in the server package, it is pointing to the cli's xvfb package here: https://github.com/cypress-io/cypress/blob/replace-xvfb-dep/scripts/binary/index.js#L26Oddly enough the
@cypress-io/xvfb
package used in the CLI is yet another fork of thexvfb
package that includes the same changes from https://github.com/cypress-io/node-xvfb. We can't patch package the CLI's xvfb package though since it's used in the CLI.I'll followup by archiving this repo: https://github.com/cypress-io/node-xvfb
Steps to test
No tests fail
How has the user experience changed?
N/A
PR Tasks
cypress-documentation
?type definitions
?