chore: change path created in prevous PR to make windows compliant #29551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
empty commit to run ci [run ci] squash this
jennifer-shehane
approved these changes
May 21, 2024
AtofStryker
force-pushed
the
chore/fix_illegal_characters_in_windows
branch
from
911ec47
to
163cf7e
Compare
ryanthemanuel
approved these changes
May 21, 2024
mschile
approved these changes
May 21, 2024
Passing run #55517 ↗︎
Details:
Review all test suite changes for PR #29551 ↗︎ |
|||||||||||||||
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Fixes illegal characters in the path name for Windows that was introduced in #29162. Other environments are fine except Windows, which means we can't clone or contributors can't pull in cypress in Windows environments.
Fails
Passes
unit test is passing with updated path
Steps to test
should be able to checkout this branch on Windows
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?