Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect proxy settings in windows #3855

Closed
brian-mann opened this issue Apr 1, 2019 · 2 comments
Closed

Automatically detect proxy settings in windows #3855

brian-mann opened this issue Apr 1, 2019 · 2 comments
Assignees

Comments

@brian-mann
Copy link
Member

@brian-mann brian-mann commented Apr 1, 2019

Problem

Windows users typically have their proxy settings configured at the system level, in the Windows registry. Specifically at HKCU:Software\Microsoft\Windows\CurrentVersion\Internet Settings.

We should read proxy settings in from the Windows registry for a couple of reasons:

  1. Users are used to desktop apps which can use the system-wide proxy automatically
  2. It's the only way to enable users of the standalone binary who need Internet access to get it.

Solution

Read in the user's proxy settings from the registry using the @cypress/get-windows-proxy module, which uses the native @cypress/registry-js module to read in the actual settings.

@brian-mann
Copy link
Member Author

@brian-mann brian-mann commented Apr 1, 2019

Fixed by #3531

@brian-mann brian-mann closed this Apr 1, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants