Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only the publix suffix registry when parsing URL's #402

Closed
brian-mann opened this issue Jan 30, 2017 · 1 comment
Closed

Use only the publix suffix registry when parsing URL's #402

brian-mann opened this issue Jan 30, 2017 · 1 comment
Assignees
@brian-mann
Labels
type: unexpected behavior User expected result, but got another
Milestone
1.4.2

Comments

@brian-mann
Copy link
Member

Currently Cypress uses the https://publicsuffix.org/learn list when parsing URL's, but it incorrectly calculates the private suffix registry which can lead to incorrect results.

Related to #380
@brian-mann brian-mann self-assigned this Jan 30, 2017
@brian-mann brian-mann added the type: unexpected behavior User expected result, but got another label Jan 30, 2017
@brian-mann brian-mann mentioned this issue May 8, 2017
Closed
@brian-mann brian-mann mentioned this issue Jan 8, 2018
Closed
@brian-mann brian-mann added this to the 1.4.2 milestone Feb 4, 2018
brian-mann added a commit that referenced this issue Feb 4, 2018
@brian-mann
server: fixes #802 and fixes #380 and fixes #402 and fixes #493 and f…
2b836a1 
…ixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly
brian-mann added a commit that referenced this issue Feb 4, 2018
@brian-mann
Issue 1175 (#1257)
e08778d 
* server: fixes #802 and fixes #380 and fixes #402 and fixes #493 and fixes #1161

- use the public suffix when parsing tld’s so that document.domain is
set correctly

* driver: move location spec back into cypress tests

* server, driver: fixes: #600 and fixes #1175 use public suffix for parsing tld, handle multiple different subdomains on cy.visit
@brian-mann
Copy link
Member Author

brian-mann commented Feb 5, 2018 •
edited
Loading

Released in 1.4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
type: unexpected behavior User expected result, but got another
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
1 participant
@brian-mann