'onBeforeLoad' in overrode 'visit' still not get called in latest v3.3.0

[freewind]

Cypress.Commands.overwrite("visit", (visit: typeof cy.visit, url: string) => {
  console.log('### visit', visit, url);
  visit(url, {
    onBeforeLoad: () => {
      console.log('### onBeforeLoad')
    }
  })
});

describe('cypress', () => {
  it('should using overrode cy.visit correctly', () => {
    cy.visit('https://example.cypress.io/');

    // if you comment the following line, `onBeforeLoad` in overrode visit will run
    cy.title().should('equal', 'Cypress.io: Kitchen Sink')
  })
})

The test passed, but no ### onBeforeLoad get printed.

You can try it in the small complete demo project: https://github.com/freewind-demos/typescript-cypress-overwrite-visit-onbeforeload-issue-demo

[jennifer-shehane]

You need to make sure to always return the original function call for the overwrite command as specified in our docs: https://on.cypress.io/custom-commands#Overwrite-visit-command

Working example:

// commands.ts

Cypress.Commands.overwrite("visit", (visit: typeof cy.visit, url: string) => {
  console.log('### visit', visit, url);
  
  return visit(url, {
    onBeforeLoad: () => {
      console.log('### onBeforeLoad')
    }
  })
});

//hello_spec.ts

it('override onBeforeLoad in cy.visit correctly', () => {
  cy.visit('https://example.cypress.io/');
})

[freewind]

Thanks! Seems like it's the typing problem:

cypress/types/index.d.ts

Commands: {
  overwrite(name: string, fn: (...args: any[]) => void): void
  overwrite(name: string, options: CommandOptions, fn: (...args: any[]) => void): void
}

The fn has void return type.