Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash due to state.json being empty #473

Closed
chrisbreiding opened this issue Mar 22, 2017 · 2 comments
Closed

Fix crash due to state.json being empty #473

chrisbreiding opened this issue Mar 22, 2017 · 2 comments
Assignees
@chrisbreiding
Labels
type: bug
Milestone
0.19.2

Comments

@chrisbreiding
Copy link
Contributor

chrisbreiding commented Mar 22, 2017 •
edited
Loading

Our fork of conf has a bug in regards to how it handles (or doesn't handle) JSON parsing errors, so if the state.json file ends up empty somehow, it will throw and crash the entire process. Need to add proper error handling.
@chrisbreiding chrisbreiding mentioned this issue Mar 22, 2017
Closed
@chrisbreiding chrisbreiding self-assigned this Mar 22, 2017
@chrisbreiding
Copy link
Contributor Author

chrisbreiding commented Mar 22, 2017 •
edited
Loading

Fixed in conf fork: cypress-io/conf@8ed2590

@brian-mann
Copy link
Member

Fixed in 0.19.2.

@brian-mann brian-mann added this to the 0.19.2 milestone May 12, 2017
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Apr 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisbreiding chrisbreiding

Labels
type: bug
Projects
None yet
Milestone
0.19.2
Development

No branches or pull requests
2 participants
@chrisbreiding @brian-mann