Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values set by plugin no longer highlighted in Test Runner Settings #6024

Closed
drewbrend opened this issue Dec 20, 2019 · 3 comments · Fixed by #6036 · May be fixed by qsays/grafana#1
Closed

Values set by plugin no longer highlighted in Test Runner Settings #6024

drewbrend opened this issue Dec 20, 2019 · 3 comments · Fixed by #6036 · May be fixed by qsays/grafana#1
Assignees
Labels
pkg/desktop-gui type: regression v3.7.0 🐛

Comments

@drewbrend
Copy link

@drewbrend drewbrend commented Dec 20, 2019

This used to work so this is a regression in 3.8.0 - or maybe earlier.

Current behavior:

Values set by plugin are not highlighted and at a glance look the same as default values. Values set by other methods are working properly.

Desired behavior:

Values set by plugin should be highlighted purple as they were previously

Steps to reproduce: (app code and test code)

  1. Set an env var in a plugin
  2. Launch Cypress Test Runner
  3. Go to the Settings tab

Versions

Cypress 3.8.0

image

@jennifer-shehane jennifer-shehane added v3.7.0 🐛 type: regression pkg/desktop-gui labels Dec 23, 2019
@cypress-bot cypress-bot bot added the stage: ready for work label Dec 23, 2019
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 23, 2019

I confirmed this was introduced in 3.7.0, likely from this PR #5067

I also confirmed that this only affects the visual display of the configuration not highlighting as the same color as 'plugin', the value is actually set and read in correctly.

3.6.1

Screen Shot 2019-12-23 at 10 07 06 AM

3.7.0

Screen Shot 2019-12-23 at 10 03 41 AM

@andrew-codes andrew-codes self-assigned this Dec 23, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review and removed stage: ready for work stage: work in progress labels Dec 23, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review labels Dec 24, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Dec 24, 2019

The code for this is done in cypress-io/cypress#6036, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Dec 26, 2019

Released in 3.8.1.

@cypress-bot cypress-bot bot removed the stage: pending release label Dec 26, 2019
@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg/desktop-gui type: regression v3.7.0 🐛
Projects
None yet
3 participants