Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus on 'Support'/'Docs' links in Desktop-GUI show white background instead of grey. #7491

Closed
jennifer-shehane opened this issue May 27, 2020 · 2 comments · Fixed by #7492
Closed

Focus on 'Support'/'Docs' links in Desktop-GUI show white background instead of grey. #7491

jennifer-shehane opened this issue May 27, 2020 · 2 comments · Fixed by #7492
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 27, 2020 •
edited
Loading

Current behavior:

After clicking on the Support/Docs links (causing focus) and going back to Desktop, the link is highlighted with a light background.

This was a regression introduced in 3.4.1, probably introduced in #4737

Screen Shot 2020-05-27 at 1 23 44 PM

Desired behavior:

Should have same style as hover.

Versions

3.4.1+
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label May 27, 2020
@jennifer-shehane jennifer-shehane added type: user experience Improvements needed for UX pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory labels May 27, 2020
@jennifer-shehane jennifer-shehane mentioned this issue May 27, 2020
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels May 27, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 1, 2020

The code for this is done in cypress-io/cypress#7492, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 8, 2020

Released in 4.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pkg/desktop-gui This is due to an issue in the packages/desktop-gui directory type: user experience Improvements needed for UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix focus style on Desktop-GUI nav for Support/Doc links cypress-io/cypress
1 participant
@jennifer-shehane