Fix focus style on Desktop-GUI nav for Support/Doc links

[jennifer-shehane]

• close Focus on 'Support'/'Docs' links in Desktop-GUI show white background instead of grey. #7491

User Facing Changelog

• The navigation links in the Test Runner now display the correct style when focused.

Additional Details

• This was introduced in this line of Issue 869 desktop gui responsive nav #4737 in 3.4.1 release. Just a miswritten css selector.
• There are no tests for this! Cypress cannot simulate css psuedo selector states on click, etc.

How has the user experience changed?

Before

After

PR Tasks

• Have tests been added/updated? No 😢 See notes.
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

• Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
• Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

• The feature/bugfix is self-documenting from within the product.
• The change provides the end user with a way to fix their problem (no dead ends).

Functionality

• The code works and performs its intended function with the correct logic.
• Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
• The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

• The code is readable (too many nested 'if's are a bad sign).
• Names used for variables, methods, etc, clearly describe their function.
• The code is easy to understood and there are relevant comments explaining.
• New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
• There are comments containing link(s) to the addressed issue (in tests and code).

Quality

• The change does not reimplement code.
• There's not a module from the ecosystem that should be used instead.
• There is no redundant or duplicate code.
• There are no irrelevant comments left in the code.
• Tests are testing the code’s intended functionality in the best way possible.

Internal

• The original issue has been tagged with a release in ZenHub.

[cypress]

---

Test summary

7425 • 0 • 104 • 0

---

Run details

Project	cypress
Status	Passed
Commit	986138e
Started	May 27, 2020 7:37 AM
Ended	May 27, 2020 7:45 AM
Duration	07:32 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[JessicaSachs]

Does this really work? I swear I tried fixing this line locally 😅

[JessicaSachs]

I don't believe this fixed the issue. I'm still getting an #eee background when a:focus in the nav. My theory is that this is the default style for bootstrap.

[JessicaSachs]

Ok it really works 😅! User error.