-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route returning 204 (No content) can't be waited for with route2 #8999
Labels
Comments
jraoult
changed the title
Route returning 204 (No content) can't be waited for
Route returning 204 (No content) can't be waited for with route2
Oct 28, 2020
This seems to happen with any empty body status code, like 304 Found, has the same behavior. |
5 tasks
3 tasks
cypress-bot
bot
added
stage: needs review
The PR code is done & tested, needs review
stage: ready for work
The issue is reproducible and in scope
and removed
stage: work in progress
stage: needs review
The PR code is done & tested, needs review
labels
Nov 5, 2020
This was referenced Nov 16, 2020
cypress-bot
bot
added
stage: needs review
The PR code is done & tested, needs review
and removed
stage: ready for work
The issue is reproducible and in scope
labels
Dec 1, 2020
cypress-bot
bot
added
stage: pending release
and removed
stage: needs review
The PR code is done & tested, needs review
labels
Dec 2, 2020
The code for this is done in cypress-io/cypress#9097, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current behavior
I'm trying to wait for this route:
My server returns a response with
204
status (a valid code for delete cf.https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/DELETE). I can see the route is intercepted thanks to the route section in the runner butwait
for this route alias always times out.If I change the server to return a
200
(even without a body) then thewait
command passes. Interestingly, in the runner's panel, the request still shows a progress bar even after thewait
passes:with a 204 status:
with a 200:
I found a workaround by adding a route handler like this:
Desired behavior
204
should get the same behaviour as200
Test code to reproduce
Versions
Cypress 5.5.0
The text was updated successfully, but these errors were encountered: