fix(net-stubbing): fix waiting on responses with no-body status codes

[flotwig]

• Closes Route returning 204 (No content) can't be waited for with route2 #8999
• Closes cy.route2 times out waiting for image load #8934

User facing changelog

• Fixed an issue where HTTP responses that cannot have a body (like HTTP 304 and HTTP 204) could not be awaited using cy.intercept.
• Fixed an issue where HTTP redirects could not be awaited using cy.intercept unless dynamically intercepted.

Additional details

• tricky because internally, Node.js treats 304s differently from 204s
• also tricky because the fix for End proxied responses for 1xx, 204, 304 with no body, fix bug where cy server could be proxied #4358 had to be maintained or else the 5 second timeout continues

How has the user experience changed?

PR Tasks

• test from RWA issue has been resolved fix(net-stubbing): fix waiting on responses with no-body status codes #9097 (comment)
• Have tests been added/updated?
• Has the original issue or this PR been tagged with a release in ZenHub?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

4446 • 0 • 49 • 2

---

Run details

Project	cypress
Status	Passed
Commit	1657874
Started	Dec 2, 2020 6:41 PM
Ended	Dec 2, 2020 6:52 PM
Duration	11:02 💡
OS	Linux Debian - 10.5
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[eilgin]

Hello @flotwig, i've just seen that cypress is now launching 6.0 (congrats!). I'd like to know if this PR is still relevant?

[flotwig]

Hello @flotwig, i've just seen that cypress is now launching 6.0 (congrats!). I'd like to know if this PR is still relevant?

@eilgin yep, this is still a work in progress, i hope to get it in the next release

[bahmutov]

wow, some people write such interesting code just to avoid ||

[flotwig]

job security

[kevinold]

@flotwig It appears that 302 POST's might also be grouped into this. See this failure when attempting to cy.intercept for /logout in the RWA.

cypress-io/cypress-realworld-app@1b54220

Test to reproduce the issue: https://github.com/cypress-io/cypress-realworld-app/pull/676/files#diff-8781249f032a90ab825382873828906eed104c18c2a93d20e9de10b4872b0df6R143

[bahmutov]

Works, verified against 304 in cypress-io/cypress-example-recipes#598

[flotwig]

@flotwig It appears that 302 POST's might also be grouped into this. See this failure when attempting to cy.intercept for /logout in the RWA.

nice, i was able to reproduce this with a simple cy.intercept('/redirect'), and it led me to fixing the underlying logic issue that was causing #8999 along with your issue with redirects. So this PR should also fix waiting on redirects.

Funnily enough, if you intercept the redirect, it does work as-is:

cypress/packages/driver/cypress/integration/commands/net_stubbing_spec.ts

Lines 1274 to 1290 in c0e14ea

	it('intercepts redirects as expected', function () {
	const href = `/fixtures/generic.html?t=${Date.now()}`
	const url = `/redirect?href=${encodeURIComponent(href)}`
	cy.intercept('/redirect', (req) => {
	req.reply((res) => {
	expect(res.statusCode).to.eq(301)
	expect(res.headers.location).to.eq(href)
	res.send()
	})
	})
	.as('redirect')
	.intercept('/fixtures/generic.html').as('dest')
	.then(() => fetch(url))
	.wait('@redirect')
	.wait('@dest')
	})

[bahmutov]

nice