Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore stderr from the CLI. Only ignore stderr from the XVFB process #921

Closed
brian-mann opened this issue Nov 16, 2017 · 2 comments
Closed

Don't ignore stderr from the CLI. Only ignore stderr from the XVFB process #921

brian-mann opened this issue Nov 16, 2017 · 2 comments
Assignees
@brian-mann
Labels
cli type: bug
Milestone
1.4.1

Comments

@brian-mann
Copy link
Member

Debug flags like DEBUG=cypress:* or NODE_DEBUG=request don't work because we're ignoring stderr from the Cypress child process.

We need to listen to stderr but just ignore the xvfb child process (which is super noisy).

We could even conditionally do that by seeing if cypress:xvfb is enabled, and if so to log those events as well.
@brian-mann brian-mann self-assigned this Nov 16, 2017
@brian-mann brian-mann mentioned this issue Nov 30, 2017
Closed
@brian-mann
Copy link
Member Author

Also need to fix electron on Windows not outputting any colors.

brian-mann added a commit that referenced this issue Dec 21, 2017
@brian-mann
cli: fixes #921 don't ignore stderr, inherit stdio on everything exce…
da7612a 
…pt when linux + xvfb

- filter out stderr messages coming from Xlib or libudev (from xvfb)
@brian-mann brian-mann added this to the 1.4.1 milestone Dec 24, 2017
@brian-mann
Copy link
Member Author

Released in 1.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
cli type: bug
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
2 participants
@brian-mann @jennifer-shehane