Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display email and message to go to onboarding when name undefined after login #14288

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 23, 2020

User Changelog

  • After login, if a name is undefined on your profile, the Test Runner will show the profile’s email and link to instructions to update the name.

Additional Details

How has the user experience changed?

Before

Screen Shot 2020-12-23 at 2 23 56 PM

After

Screen Shot 2020-12-23 at 2 28 15 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

…defined

- Write tests to cover new empty name state after login
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 23, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 23, 2020



Test summary

9173 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 56d808d
Started Dec 23, 2020 8:20 AM
Ended Dec 23, 2020 8:33 AM
Duration 13:02 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane merged commit 190c70b into develop Dec 23, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 4, 2021

Released in 6.2.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.2.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants