Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated cy.intercept to automatically parse more JSON MIME types #15129

Merged
merged 3 commits into from
Feb 22, 2021

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Feb 17, 2021

User facing changelog

  • BREAKING CHANGE: Updated cy.intercept to automatically parse more JSON MIME types, including 'application/vnd.api+json'.
    • This may remove the need to JSON.parse(req.body) or JSON.parse(res.body) manually in tests.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@flotwig flotwig added the type: breaking change Requires a new major release version label Feb 17, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 17, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Feb 17, 2021



Test summary

9327 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 16bc149
Started Feb 18, 2021 3:43 PM
Ended Feb 18, 2021 3:54 PM
Duration 10:42 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@bahmutov bahmutov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works, and since you added tests, should work

@bahmutov
Copy link
Contributor

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking change Requires a new major release version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants