fix: Prevent selecting an option in a disabled fieldset
#15682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
herecydev
changed the title
option in a disabled fieldset
herecydev
changed the title
option in a disabled fieldsetoption in a disabled fieldset
jennifer-shehane
requested review from
jennifer-shehane
and removed request for
jennifer-shehane
herecydev
requested review from
chrisbreiding and
kuceb
and removed request for
a team
chrisbreiding
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5951
User facing changelog
We now throw an error when attempting to .select() an
<option>within a disabled<fieldset>. Fixes #5951.Additional details
Uses
getActiveElByDocumentto check whether the select field still has focus when clicked.