Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update copy and icons on runs tab #15790

Merged
merged 11 commits into from Apr 13, 2021
Merged

fix: update copy and icons on runs tab #15790

merged 11 commits into from Apr 13, 2021

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Apr 5, 2021

User facing changelog

Updates our runs tab views to encourage users to sign up for the dashboard - most likely something that does not need to be included in the public changelog

Updates both the header text and the "What is Cypress Dashboard?" section with new icons and copy

Also updated / consolidated some tests duplicated across different spec files

How has the user experience changed?

Note - the first icon + text now reads "scale your test runs..." rather than "speed up test runs..."

Logged out without projectId
Before
Screen Shot 2021-04-09 at 15 52 45

After
Note: previously users would click connect and be presented with the log in modal where they would have to click again to be sent to the dashboard to log in - they're now directly sent to the dashboard on the first click. Also fixes an issue where UTM parameters were not properly being sent for this action in the past
Screen Shot 2021-04-09 at 15 50 31

Logged in without projectId
Before
Screen Shot 2021-04-09 at 15 52 45

After
Screen Shot 2021-04-09 at 15 50 44

Not logged in without projectId
Before
Screen Shot 2021-04-09 at 15 53 12

After
Screen Shot 2021-04-09 at 15 50 54

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Thanks for taking the time to open a PR!

@panzarino panzarino marked this pull request as ready for review April 9, 2021 19:55
@panzarino panzarino requested a review from a team as a code owner April 9, 2021 19:55
@cypress
Copy link

cypress bot commented Apr 9, 2021



Test summary

4021 0 49 2Flakiness 0


Run details

Project cypress
Status Passed
Commit e637287
Started Apr 13, 2021 8:43 PM
Ended Apr 13, 2021 8:54 PM
Duration 10:48 💡
OS Linux Debian - 10.8
Browser Chrome 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino merged commit a4df991 into develop Apr 13, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2021

Released in 7.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants