Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change binary of VS Code editor found on windows to match default install #16355

Merged
merged 1 commit into from
May 10, 2021

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented May 5, 2021

User facing changelog

Cypress will now detect the default installation location of the Visual Studio Code editors on Windows machines.

Additional details

  • I just set up a Windows VM and this was where VS Code installs by default, with no .exe extension.
  • I manually tested that this change detects VS Code on my Windows VM now by default.

How has user experience changed

Before

Didn’t detect my VS Code in Windows

Screen Shot 2021-05-05 at 2 07 34 PM

After

Now detects my VS Code in Windows

Screen Shot 2021-05-05 at 2 29 03 PM

PR Tasks

  • Tests? I manually tested, not sure there’s much to do beyond that
  • Zenhub release tag

@jennifer-shehane jennifer-shehane requested a review from a team as a code owner May 5, 2021 19:31
@jennifer-shehane jennifer-shehane requested review from flotwig and chrisbreiding and removed request for a team May 5, 2021 19:31
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 5, 2021

Thanks for taking the time to open a PR!

binary: 'Code.exe',
binary: 'code',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that there's no .exe, but was there one before? i.e. is this going to break code detection for older vscode users?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pft, I dunno, was going to ask @chrisbreiding how he determined the list to begin with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly where this list came from. I thought I had left comments in the code pointing the source, but I guess not. I think I compiled it from a few different sources, like env-editor, but I'm not sure where precisely I got the VSCode binary value for Windows. I didn't manually test out each editor on each OS, so it's possible it has always been wrong, or it's equally possible it has changed at some point from Code.exe to Code since this was implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode not auto discovered for file opener preference in Windows 10
3 participants