feat(driver): add select by index

[davidmunechika]

Closes #757

User facing changelog

Users now have the ability to select an option by index within the .select() command.

Additional details

These are now the updated accepted arguments for the .select() command:

.select(value)
.select(values)
.select(value, options)
.select(values, options)

value can be the value, index, or text content of the option to be selected
values is an array of values, indexes, or text contents of the options to be selected
Updated documentation: cypress-io/cypress-documentation#4105

Tests

Additional tests added include:

• Ability to select by index
• Can select an array with multiple indexes
• Can select an array with same value and index
• Throws error if given negative index
• Throws error if given non-integer index

PR Tasks

• Have tests been added/updated?
• Has the original issue or this PR been tagged with a release in ZenHub?
• Has a PR for user-facing changes been opened in cypress-documentation? Add Select By Index cypress-documentation#4105
• Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[CLAassistant]

All committers have signed the CLA.

[cypress]

---

Test summary

18502 • 0 • 214 • 7 • 1

---

Run details

Project	cypress
Status	Passed
Commit	745c46c
Started	Sep 24, 2021 7:57 PM
Ended	Sep 24, 2021 8:07 PM
Duration	10:31 💡
OS	Linux Debian - 10.9
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Flakiness

	cypress/integration/cypress/proxy-logging-spec.ts		1
1	... > works with forceNetworkError

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

The code looks great and well tested. Nice first PR. 🎉 There's one edge case not considered and just another note I ran across with select in general. I left a couple notes inline in the code as well.

1. Users passing in an option of an index that doesn't exist in the select needs to be considered.

<select>
  <option>zero</option>
<select>

cy.select(3)

The error message here is confusing as it says it's looking for text/value of 3 and can't find it.

2. This is actually not within the scope of work outlined (this is an existing issue before this PR), so perhaps you could make a new issue for this, but if you call cy.select() with no value then there's a weird error. It should say something along the lines of - cy.select wasn't called with any value, text, index, etc etc.

[jennifer-shehane]

I'm not sure why Percy is failing here. Should be able to be ignored though since this definitely doesn't touch the UI that Percy is checking.

[jennifer-shehane]

Great! 💯