fix(vite-dev-server): windows supportFile + preserve optimize entries
#18286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- preserve `optimizedDeps.entries` configured on target project - transform windows absolute paths to relative - transform windows paths to use `/` to match fast glob patterns
|
Thanks for taking the time to open a PR!
|
userquin
changed the title
supportFile + preserve optimize entries
|
@lmiller1990 feel free to change to ready to review if there is no need to add tests for preserve optimizeDeps entries and merge when necessary. |
lmiller1990
reviewed
Sep 29, 2021
lmiller1990
approved these changes
Sep 29, 2021
|
I will hold off on merging until our semantic release step is fixed, it's currently failing on CI. It should be resolved soon. Thanks! |
|
@lmiller1990 adding the |
We can add the support file if there are no specs. That's fine. We can go either way, honestly. |
JessicaSachs
approved these changes
Oct 1, 2021
JessicaSachs
changed the title
supportFile + preserve optimize entriessupportFile + preserve optimize entries
tgriesser
added a commit
that referenced
this pull request
Oct 8, 2021
* develop: (31 commits) fix: `everyNthFrame` should only be applied for Chrome 89+ (#18392) docs: General updates to contributing guide (#18283) chore: Update Chrome (beta) to 95.0.4638.40 (#18389) chore: use circleci timings split for e2e tests (#18367) fix: fixed title (#18370) chore(deps): update dependency electron to v14 🌟 (#18384) chore(server): share client route (#18215) fix: Prevent Cypress from crashing when argument parsing "spec: {}" (#18312) chore: update husky dev dependency to v7 (#18345) feat: add defineConfig function to help type config (#18302) chore: Update Chrome (stable) to 94.0.4606.71 (#18324) feat: allow to use TypeScript in the config file (#18300) allow select to be called with empty array (#18329) fix(vite-dev-server): windows `supportFile` + preserve optimize entries (#18286) chore: fix semantic-release dry run (#18332) fix(driver): improve status_code_flags_invalid error message (#18316) chore(deps): update dependency electron to v13.5.0 🌟 (#18318) chore: Update Chrome (stable) to 94.0.4606.61 and Chrome (beta) to 95.0.4638.32 (#18229) fix(proxy-logging): use constant consoleProps object (#18207) feat(driver): Add "overwrite" option to cy.screenshot() (#18280) ...
tgriesser
added a commit
that referenced
this pull request
Oct 8, 2021
* develop: (33 commits) fix: remove .json check from require_async, prevent child_process spawn (#18416) percy snapshot the tooltip visually, prevent it from being hidden fix: `everyNthFrame` should only be applied for Chrome 89+ (#18392) docs: General updates to contributing guide (#18283) chore: Update Chrome (beta) to 95.0.4638.40 (#18389) chore: use circleci timings split for e2e tests (#18367) fix: fixed title (#18370) chore(deps): update dependency electron to v14 🌟 (#18384) chore(server): share client route (#18215) fix: Prevent Cypress from crashing when argument parsing "spec: {}" (#18312) chore: update husky dev dependency to v7 (#18345) feat: add defineConfig function to help type config (#18302) chore: Update Chrome (stable) to 94.0.4606.71 (#18324) feat: allow to use TypeScript in the config file (#18300) allow select to be called with empty array (#18329) fix(vite-dev-server): windows `supportFile` + preserve optimize entries (#18286) chore: fix semantic-release dry run (#18332) fix(driver): improve status_code_flags_invalid error message (#18316) chore(deps): update dependency electron to v13.5.0 🌟 (#18318) chore: Update Chrome (stable) to 94.0.4606.61 and Chrome (beta) to 95.0.4638.32 (#18229) ...
mjhenkes
pushed a commit
that referenced
this pull request
Jul 28, 2022
…es (#18286) Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fix and closes #18261
optimizedDeps.entriesconfigured on target projecttransform windows absolute paths to relative/to match fast glob patternsHow to test
yarn && yarn build --scope npm/vite-dev-server && cd npm/vite-dev-server && yarn link.yarn && yarn link "@cypress/vite-dev-server"package.jsonand change"@cypress/vite-dev-server": "2.1.0"with"@cypress/vite-dev-server": "0.0.0-development"yarn test:component:run: the result should be the expectedyarn test:component:runfrom previous step again, deletenode_modules/.vitedirectory before run it againOnce finished testing, unlink from
npm/vite-dev-serverpackage and from target project.Current Behavior
see #18261
New Behavior
optimizeDeps.entriesentries should be preservedTests
PENDING (this is why is on draft)