-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 'slowTestThreshold' and fix this.slow()
inside specs
#18371
feat: Add 'slowTestThreshold' and fix this.slow()
inside specs
#18371
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…Change to 10000ms default
be506fb
to
203072f
Compare
…side tests, hooks and suites.
…shold inside tests, hooks and suites." This reverts commit 1496833.
After struggling with it for a bit, I've eventually decided not to throw errors if the user uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Latest commit fixes Still TODO:
|
this.slow()
inside specs
037edc3
to
a2784af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the nitpicks about yellow vs orange, looks great.
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
User facing changelog
slowTestThreshold
config option to customize slow test thresholdspec
reporter, this will hide test timing for any test under 5000ms. To restore the old behavior, you can add"slowTestThreshold": 75
to your cypress configuration.Additional details
A test that executes for half of the “slowTestThreshows” time will be highlighted in yellow with the default spec reporter; a test that executes for entire “slow” time will be highlighted in red. This is a visual change only - slow tests still pass. See https://mochajs.org/#-slow-ms-s-ms for more details.
PR Tasks
cypress-documentation
? Add documentation for new slowTestThreshold config option cypress-documentation#4145 requires reworkingtype definitions
?cypress.schema.json
?