Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(driver): Sticky elements within a fixed container will not prevent an element from being scrolled to #18441

Merged
merged 31 commits into from
Nov 2, 2021
Merged

fix(driver): Sticky elements within a fixed container will not prevent an element from being scrolled to #18441

merged 31 commits into from
Nov 2, 2021

Commits on Oct 6, 2021

  1. add test

    @davidmunechika
    davidmunechika committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    271dcbd View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. try other scroll behavior options

    @davidmunechika
    davidmunechika committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    43fb341 View commit details
    Browse the repository at this point in the history

  2. refactor scroll until visible

    @davidmunechika
    davidmunechika committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    496945b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. allow overriding with scrollBehavior

    @davidmunechika
    davidmunechika committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    f3d05c6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    c833f0b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. add comment 

    Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
    @davidmunechika @chrisbreiding
    davidmunechika and chrisbreiding committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    95d2211 View commit details
    Browse the repository at this point in the history

  2. rename userSetScrollBehavior 

    Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
    @davidmunechika @chrisbreiding
    davidmunechika and chrisbreiding committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    0195ca0 View commit details
    Browse the repository at this point in the history

  3. refactor if else

    @davidmunechika
    davidmunechika committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    4f254e6 View commit details
    Browse the repository at this point in the history

  4. add custom scroll behavior test

    @davidmunechika
    davidmunechika committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5af31e0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    d57dd85 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. add tests for other scrolling commands

    @davidmunechika
    davidmunechika committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    3d0cebb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue-4233-click-sticky-element' of https://github.com/… 

    …cypress-io/cypress into issue-4233-click-sticky-element
    @davidmunechika
    davidmunechika committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5e8deda View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    5d688da View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. refactor scrollBehavior option

    @davidmunechika
    davidmunechika committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    2bd2851 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue-4233-click-sticky-element' of https://github.com/… 

    …cypress-io/cypress into issue-4233-click-sticky-element
    @davidmunechika
    davidmunechika committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    1f83d11 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    f0ddb9b View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. refactor ensure visibility

    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    28834b5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue-4233-click-sticky-element' of https://github.com/… 

    …cypress-io/cypress into issue-4233-click-sticky-element
    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    3d8eb4c View commit details
    Browse the repository at this point in the history

  3. remove chai import

    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    2f9a14f View commit details
    Browse the repository at this point in the history

  4. fix trigger test

    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    981f297 View commit details
    Browse the repository at this point in the history

  5. remove user set scroll behavior

    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    7a0b1c1 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    2e9207c View commit details
    Browse the repository at this point in the history

  7. fix clear spec

    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    15a22b5 View commit details
    Browse the repository at this point in the history

  8. fix error message

    @davidmunechika
    davidmunechika committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    2bccbff View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. fix select case

    @davidmunechika
    davidmunechika committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    b0b348b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    8330767 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. update tests

    @davidmunechika
    davidmunechika committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    f2a4b1f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue-4233-click-sticky-element' of https://github.com/… 

    …cypress-io/cypress into issue-4233-click-sticky-element
    @davidmunechika
    davidmunechika committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    dbbe481 View commit details
    Browse the repository at this point in the history

  3. add comment

    @davidmunechika
    davidmunechika committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    1de8681 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    1d0f1f7 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Merge branch 'develop' into issue-4233-click-sticky-element

    @davidmunechika
    davidmunechika committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    5aa6dc7 View commit details
    Browse the repository at this point in the history