fix: server cypress_spec permissions test now passes #18445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
BlueWinds
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
davidmunechika
requested review from
flotwig and
emilyrohrbough
and removed request for
a team
flotwig
suggested changes
Oct 14, 2021
Co-authored-by: Zach Bloomquist <github@chary.us>
emilyrohrbough
approved these changes
Oct 14, 2021
flotwig
approved these changes
Oct 14, 2021
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Bugfix for
yarn test-integration --scope @packages/serverwhen run with non-root permissionsAdditional details
logs error and exits when project folder has read permissions only and cannot write cypress.jsontest had a bug, causing it to fail when run as a non-root user (and to be skipped when run as root). No longer - the test now runs and passes regardless of environment.PR Tasks