Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server cypress_spec permissions test now passes #18445

Merged
merged 3 commits into from Oct 14, 2021

Conversation

BlueWinds
Copy link
Contributor

User facing changelog

Bugfix for yarn test-integration --scope @packages/server when run with non-root permissions

Additional details

  • The logs error and exits when project folder has read permissions only and cannot write cypress.json test had a bug, causing it to fail when run as a non-root user (and to be skipped when run as root). No longer - the test now runs and passes regardless of environment.

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2021

Thanks for taking the time to open a PR!

@BlueWinds BlueWinds changed the title Fix cypress_spec to run permissions test locally fix: server cypress_spec permissions test now passes Oct 11, 2021
@cypress
Copy link

cypress bot commented Oct 11, 2021



Test summary

18544 0 214 7Flakiness 0


Run details

Project cypress
Status Passed
Commit d517793
Started Oct 14, 2021 4:56 PM
Ended Oct 14, 2021 5:09 PM
Duration 13:20 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davidmunechika davidmunechika marked this pull request as ready for review October 13, 2021 15:34
@davidmunechika davidmunechika requested a review from a team as a code owner October 13, 2021 15:34
@davidmunechika davidmunechika requested review from flotwig and emilyrohrbough and removed request for a team October 13, 2021 15:34
@BlueWinds BlueWinds removed their assignment Oct 13, 2021
packages/server/lib/scaffold.js Outdated Show resolved Hide resolved
Co-authored-by: Zach Bloomquist <github@chary.us>
@BlueWinds BlueWinds merged commit f4fee90 into develop Oct 14, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 25, 2021

Released in 8.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants