feat(app): run e2e tests #18448
feat(app): run e2e tests #18448
Conversation
|
Thanks for taking the time to open a PR!
|
| @@ -82,8 +82,8 @@ export const runner = { | |||
| return serveRunner(runnerPkg, config, res) | |||
| }, | |||
|
|
|||
| handle (testingType, req, res) { | |||
| const pathToFile = getPathToDist(testingType === 'e2e' ? 'runner' : 'runner-ct', req.params[0]) | |||
| handle (testingType: Cypress.TestingType, req: Request, res: Response) { | |||
There was a problem hiding this comment.
Since we are building driver and reporter by webpack, and the entry point for that bundle is runner-ct/src/main.tsx, whenever we run the new app (as decided by the LAUNCHPAD variable) we always want to server runner-ct, unless running suites like driver under the existing e2e runner.
| @@ -8,6 +8,11 @@ import type { Server } from 'http' | |||
| import { SocketIOServer } from '@packages/socket' | |||
|
|
|||
| let graphqlServer: Server | undefined | |||
| let graphqlPort: number | undefined | |||
|
|
|||
| export function getExistingGraphqlServerPort () { | |||
There was a problem hiding this comment.
Need some way to access this - somehow the new app needs to be able to access this when it creates its urql client, the only way I could come up with was passing it as a query param (like we are doing in launchpad).
Bit of a hack, definitely not ideal long term. @tgriesser any ideas how I can pass the gql port to the front-end (bearing in mind we currently need to manually change to __vite__ to use the new app).
lmiller1990
requested review from
BlueWinds,
emilyrohrbough and
tgriesser
and removed request for
a team,
BlueWinds and
emilyrohrbough
…ramework * unified-desktop-gui: fix conflicts fix conflicts feat: create a copy when selecting a pre-existing story (#18440) feat: add configured state to TestingTypeCard (#18461) feat(app): run e2e tests (#18448) fix: frontend-shared typo on windi config feat: make the select language component (#18443) chore: Update Chrome (stable) to 94.0.4606.81 (#18411) release 8.6.0 fix: do not attempt to trim objects when printing to console (#18341) fix(driver): `cy.pause()` should not be ignored with `cypress run --headed --no-exit` (#18358) chore: release @cypress/vite-dev-server-v2.1.1 chore: release @cypress/react-v5.10.1
Get E2E specs running in the new runner.
TODO:
gqlPortin query string. Not sure on the best way to get this, for now I just copied what we do in launchpad and stuck it in the?gqlPort=<port>.