Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Next.JS 12 components testing failing with TypeError: Cannot read property 'traceChild' of undefined #18648

Merged
merged 4 commits into from
Oct 27, 2021
Merged

fix: Next.JS 12 components testing failing with TypeError: Cannot read property 'traceChild' of undefined #18648

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71a9f35
fix:Support for Next.JS 12 components testing
pbilyk Oct 26, 2021
115652a
update nextjs version to 12
pbilyk Oct 26, 2021
7c324f9
Revert "update nextjs version to 12"
pbilyk Oct 27, 2021
5ae85d0
Add ts ignore for trace import from the next 12
pbilyk Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions npm/react/plugins/next/getRunWebpackSpan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,21 @@ import type { Span } from 'next/dist/telemetry/trace/trace'
// Starting with v11.1.1, a trace is required.
// 'next/dist/telemetry/trace/trace' only exists since v10.0.9
// and our peerDeps support back to v8 so try-catch this import
// Starting from 12.0 trace is now located in 'next/dist/trace/trace'
export async function getRunWebpackSpan (): Promise<{ runWebpackSpan?: Span }> {
let trace: (name: string) => Span

try {
trace = await import('next/dist/telemetry/trace/trace').then((m) => m.trace)
try {
trace = await import('next/dist/telemetry/trace/trace').then((m) => m.trace)

return { runWebpackSpan: trace('cypress') }
return { runWebpackSpan: trace('cypress') }
}
catch (_){
trace = await import('next/dist/trace/trace').then((m) => m.trace)
pbilyk marked this conversation as resolved.
Show resolved Hide resolved

return { runWebpackSpan: trace('cypress') }
}
} catch (_) {
return {}
}
Expand Down