Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add percy to app and launchpad package #18781

Merged
merged 6 commits into from
Nov 4, 2021

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Nov 4, 2021

Adding percy to app/launchpad/frontend-shared! For your presentational components, just add a cy.percySnapshot() at the end to verify everything looks right and continues to do so.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 4, 2021

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 changed the title Lmiller1990/add percy chore: add percy to app package Nov 4, 2021
@cypress
Copy link

cypress bot commented Nov 4, 2021



Test summary

4802 1 52 2Flakiness 2


Run details

Project cypress
Status Failed
Commit e2b817f
Started Nov 4, 2021 12:22 PM
Ended Nov 4, 2021 12:33 PM
Duration 11:30 💡
OS Linux Debian - 10.9
Browser Electron 93

View run in Cypress Dashboard ➡️


Failures

cypress/integration/e2e/redirects_spec.js Failed
1 redirection > meta > binds to the new page after a timeout

Flakiness

settings_spec.js Flakiness
1 Settings > file preference panel > loads preferred editor and available editors
commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 marked this pull request as ready for review November 4, 2021 12:22
@lmiller1990 lmiller1990 requested a review from a team November 4, 2021 12:23
@lmiller1990 lmiller1990 changed the title chore: add percy to app package chore: add percy to app and launchpad package Nov 4, 2021
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lmiller1990 lmiller1990 merged commit e2735de into unified-desktop-gui Nov 4, 2021
@lmiller1990 lmiller1990 deleted the lmiller1990/add-percy branch November 4, 2021 13:03
tgriesser added a commit that referenced this pull request Nov 4, 2021
* unified-desktop-gui:
  chore: add percy to app and launchpad package (#18781)
  chore: update test
  refactor: move settings in app (#18729)
  feat: setup launchpad lifecycle (#18734)
tgriesser added a commit that referenced this pull request Nov 4, 2021
…ve-activeProject

* unified-desktop-gui: (57 commits)
  chore: Add e2e tests for global mode (#18719)
  chore: add percy to app and launchpad package (#18781)
  chore: update test
  refactor: move settings in app (#18729)
  feat: setup launchpad lifecycle (#18734)
  feat(app): decouple event manager from driver (#18695)
  chore: Force single resolution for core modules, infinite loop guard (#18764)
  fix(driver): Sticky elements within a fixed container will not prevent an element from being scrolled to (#18441)
  chore: cleaning up the runner container pattern (#18741)
  feat: Use .config files (#18578)
  chore(app): basic style and example to stop scrollIntoView bug (#18736)
  chore: make `create` function on server.ts obsolete (#18615)
  feat: add codegen utility (#18708)
  docs: Add instructions to squash commits to develop in Contributing (#18728)
  fix(@cypress/react): throw if using Next.js swc-loader without nodeVersion=system (#18686)
  refactor: remove Ramda (#18723)
  fix: support using create-cypress-tests as part of build process (#18714)
  chore: Increase paralleled machines for desktop-gui tests (#18725)
  fix(app): do not cache graphql (#18716)
  chore: Update Chrome (stable) to 95.0.4638.69 (#18696)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants