Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle testFiles depending of testing type #19075

Closed

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Nov 23, 2021

  • Closes

User facing changelog

Additional details

Currently, we were ignoring testFiles from the testing type config, now, we are able to get the value from the config file depending of selected testing type

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 23, 2021

Thanks for taking the time to open a PR!

@estrada9166 estrada9166 requested a review from a team as a code owner November 23, 2021 21:57
@estrada9166 estrada9166 requested review from jennifer-shehane and removed request for a team November 23, 2021 21:57
@jennifer-shehane jennifer-shehane removed their request for review November 23, 2021 21:58
@estrada9166 estrada9166 marked this pull request as draft November 23, 2021 22:03
@cypress
Copy link

cypress bot commented Nov 23, 2021



Test summary

18145 0 202 0Flakiness 2


Run details

Project cypress
Status Passed
Commit f07c0de
Started Nov 30, 2021 8:23 PM
Ended Nov 30, 2021 8:36 PM
Duration 12:18 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@estrada9166 estrada9166 marked this pull request as ready for review November 30, 2021 20:18
@estrada9166
Copy link
Member Author

@estrada9166 estrada9166 closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant